请分析下面英语句子结构及时态：The dream he had had for so many years ended there.整个句子是一般过去时吗?主语是The dream he had had for so many years ,ended是整句的谓语动词?he had had for so many years是一个定语从句,用来修饰The dream的,定语从句是过去完成时,第一个had表时态,第二个had是have（有）的过去分词?还有 he had had for so many years 作为定语从句,中间好像省略了连接词,省略的是什么?

你好！你解释得完全正确。
he had had for so many years 作为定语从句，the dream作先行词，因为先行词（the dream）在定语从句中作（had 的）宾语，因此可以省略关系代词that 或which 。

所有的解释都对，定语从句中省略的是宾语The dream (that) he had had for so many years ended there.
整个句子主语是The dream ，后面的定语从句he had had for so many years ，省略了宾语，意思是他拥有这个梦想很多年了，he had had （the dream) for so many years ，在定语从句中，用THAT代替the dream

你的理解很对!
The dream【( that /which)he had had for so many years】 ended there.
he had had for so many years 为定语从句,修饰the dream,中间省略了引导词that/which,由于先行词dream为“物”,故用which/that指代,但夲句引导词作为had had 的宾语,所以能省略.

你分析的对。连接词可以用that。